The Good Patch

qgil (Talk | contribs)
(Based on Andre Klapper's input)
Newer edit →

Revision as of 10:40, 24 November 2008

Characteristics of The Good Patch

A detailed and technical complement to the Maemo contribution guidelines.

  • The Good Patch should not generate any more compile time warnings than were already there.
  • The Good Patch should not include any commented code lines from tests.
  • The Good Patch should not add any extra debug printing unless absolutely necessary.
  • The Good Patch should match the Coding Style of the existing source file, e.g. with regard to indentation and whitespaces etc.
  • When attaching The Good Patch in bugs.maemo.org, add the "patch" keyword to the bug report.